Page 1 of 1

web client is allowing roster saves with bad salary cap

Posted: Fri Oct 27, 2023 4:01 am
by ynohtna
Hi

I see lines loaded by web client but still there is a salary cap error

[2023-10-26 11:38:54 PM] JMXpress are expected to be over the salary cap by $2,415,676!
[2023-10-26 11:38:43 PM] Successfully loaded JMXpress lines done with Web Base Client and SQLite Database from IP:173.180.15.124 .

Can this be fixed?

Re: web client is allowing roster saves with bad salary cap

Posted: Thu Nov 16, 2023 3:56 pm
by SimonT
Sadly, the WebClient doesn't check if the new roster salary cap is correct or not.

Re: web client is allowing roster saves with bad salary cap

Posted: Tue Nov 21, 2023 1:57 am
by ynohtna
So it won't be able to ever?

Re: web client is allowing roster saves with bad salary cap

Posted: Tue Nov 21, 2023 1:38 pm
by SimonT
It's a very complexe calculation to do in Javascript and the STHS has multiple option for salary cap. So it's even more complexe calculation in Javascript. It's doable but Javascript is not something I'm very good at. :(

Re: web client is allowing roster saves with bad salary cap

Posted: Wed Nov 22, 2023 1:38 am
by ynohtna
I guess the Player Salary Cap hit in the Roster menu of the STHS application is not a persistent field? It's a calculated value?

I'm just thinking out loud here but if there is a persistent field to store that value, and then the web client can have something to use to do a more simple sum calculation?

It would probably affect the simulator performance though to calculate every player's remaining salary cap hit and store the value :)

Re: web client is allowing roster saves with bad salary cap

Posted: Sat Nov 25, 2023 10:23 am
by JimToupet
I'll take a look if I can make something.

The Javascript part of the WebClient is a mess IMHO.

Re: web client is allowing roster saves with bad salary cap

Posted: Tue Jan 02, 2024 2:23 am
by ynohtna
JimToupet wrote: Sat Nov 25, 2023 10:23 am I'll take a look if I can make something.

The Javascript part of the WebClient is a mess IMHO.
Ooops, missed this reply, thank you for considering it!

Happy New Year, hope you and everyone had a great holiday season!

Re: web client is allowing roster saves with bad salary cap

Posted: Wed Jan 03, 2024 11:05 am
by SimonT
In the next version of the STHS, the Web Client will now print a transaction log when a GM saved his roster and lines up by the WebClient. The time for this transaction will be based on your time of the webserver, normally the GMT time.

Re: web client is allowing roster saves with bad salary cap

Posted: Thu Jan 04, 2024 2:37 am
by ynohtna
Thanks, I'm wondering though, does it help the web client prevent bad roster saves due to salary cap issues?

Re: web client is allowing roster saves with bad salary cap

Posted: Thu Jan 04, 2024 8:29 am
by SimonT
ynohtna wrote: Thu Jan 04, 2024 2:37 am Thanks, I'm wondering though, does it help the web client prevent bad roster saves due to salary cap issues?
No.