web client is allowing roster saves with bad salary cap

Any questions related to version 2 or version 3 should be ask here. / Toutes les questions sur la version 2 ou la version 3 devraient être demandées ici.
Post Reply
ynohtna
The Addict / Le Drogué
Posts: 770
Joined: Mon Aug 14, 2006 5:15 pm
Location: Vancouver, BC
Contact:

web client is allowing roster saves with bad salary cap

Post by ynohtna »

Hi

I see lines loaded by web client but still there is a salary cap error

[2023-10-26 11:38:54 PM] JMXpress are expected to be over the salary cap by $2,415,676!
[2023-10-26 11:38:43 PM] Successfully loaded JMXpress lines done with Web Base Client and SQLite Database from IP:173.180.15.124 .

Can this be fixed?
BFHL Admin/Commish
http://www.thebfhl.ca/bfhl
Now in Season 15, using BRHL Player v2.1 Ratings modified.
SimonT
STHS Owner / Propriétaire du STHS
Posts: 14775
Joined: Sat Oct 08, 2005 4:18 pm
Location: Montreal, Canada
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by SimonT »

Sadly, the WebClient doesn't check if the new roster salary cap is correct or not.
-SimonT
Forum Administrator / Administrateur du Forum
STHS Owner / Propriètaire du STHS
English V2 & V3 Manual - Manuel V2 & V3 Français
ynohtna
The Addict / Le Drogué
Posts: 770
Joined: Mon Aug 14, 2006 5:15 pm
Location: Vancouver, BC
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by ynohtna »

So it won't be able to ever?
BFHL Admin/Commish
http://www.thebfhl.ca/bfhl
Now in Season 15, using BRHL Player v2.1 Ratings modified.
SimonT
STHS Owner / Propriétaire du STHS
Posts: 14775
Joined: Sat Oct 08, 2005 4:18 pm
Location: Montreal, Canada
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by SimonT »

It's a very complexe calculation to do in Javascript and the STHS has multiple option for salary cap. So it's even more complexe calculation in Javascript. It's doable but Javascript is not something I'm very good at. :(
-SimonT
Forum Administrator / Administrateur du Forum
STHS Owner / Propriètaire du STHS
English V2 & V3 Manual - Manuel V2 & V3 Français
ynohtna
The Addict / Le Drogué
Posts: 770
Joined: Mon Aug 14, 2006 5:15 pm
Location: Vancouver, BC
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by ynohtna »

I guess the Player Salary Cap hit in the Roster menu of the STHS application is not a persistent field? It's a calculated value?

I'm just thinking out loud here but if there is a persistent field to store that value, and then the web client can have something to use to do a more simple sum calculation?

It would probably affect the simulator performance though to calculate every player's remaining salary cap hit and store the value :)
BFHL Admin/Commish
http://www.thebfhl.ca/bfhl
Now in Season 15, using BRHL Player v2.1 Ratings modified.
JimToupet
STHS Dynamic Website Contributor
Posts: 363
Joined: Wed Jul 02, 2014 10:55 am

Re: web client is allowing roster saves with bad salary cap

Post by JimToupet »

I'll take a look if I can make something.

The Javascript part of the WebClient is a mess IMHO.
ynohtna
The Addict / Le Drogué
Posts: 770
Joined: Mon Aug 14, 2006 5:15 pm
Location: Vancouver, BC
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by ynohtna »

JimToupet wrote: Sat Nov 25, 2023 10:23 am I'll take a look if I can make something.

The Javascript part of the WebClient is a mess IMHO.
Ooops, missed this reply, thank you for considering it!

Happy New Year, hope you and everyone had a great holiday season!
BFHL Admin/Commish
http://www.thebfhl.ca/bfhl
Now in Season 15, using BRHL Player v2.1 Ratings modified.
SimonT
STHS Owner / Propriétaire du STHS
Posts: 14775
Joined: Sat Oct 08, 2005 4:18 pm
Location: Montreal, Canada
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by SimonT »

In the next version of the STHS, the Web Client will now print a transaction log when a GM saved his roster and lines up by the WebClient. The time for this transaction will be based on your time of the webserver, normally the GMT time.
-SimonT
Forum Administrator / Administrateur du Forum
STHS Owner / Propriètaire du STHS
English V2 & V3 Manual - Manuel V2 & V3 Français
ynohtna
The Addict / Le Drogué
Posts: 770
Joined: Mon Aug 14, 2006 5:15 pm
Location: Vancouver, BC
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by ynohtna »

Thanks, I'm wondering though, does it help the web client prevent bad roster saves due to salary cap issues?
BFHL Admin/Commish
http://www.thebfhl.ca/bfhl
Now in Season 15, using BRHL Player v2.1 Ratings modified.
SimonT
STHS Owner / Propriétaire du STHS
Posts: 14775
Joined: Sat Oct 08, 2005 4:18 pm
Location: Montreal, Canada
Contact:

Re: web client is allowing roster saves with bad salary cap

Post by SimonT »

ynohtna wrote: Thu Jan 04, 2024 2:37 am Thanks, I'm wondering though, does it help the web client prevent bad roster saves due to salary cap issues?
No.
-SimonT
Forum Administrator / Administrateur du Forum
STHS Owner / Propriètaire du STHS
English V2 & V3 Manual - Manuel V2 & V3 Français
Post Reply